Watermark Branding
Forum Replies Created
-
The real solution is to declare the typed properties at the top of the class as this will change from a deprecation warning to an error in PHP 9.0:
class Flexy_Breadcrumb_Trail {
public string $before_wrap = '';
public string $after_wrap = '';Forum: Fixing WordPress
In reply to: Documentation for block markup@threadi Thanks for the response, very helpful.
Forum: Fixing WordPress
In reply to: Documentation for block markupSo this looks like the closest thing to what I’m looking for (scroll down to see settings/properties listing). It would be nice to see an official version of this alongside visual examples of what the various layout settings produce.
Forum: Fixing WordPress
In reply to: Reference for block options@bvbaked This is exactly what I was looking for but I suppose didn’t no how to search for properly. Thanks very much! Yeah, so I guess it’s not a macro replacement that is happening but a JSON object is being parsed from the HTML comment.
I’m going to look to see if I can’t figure out what the issue is based on the reference, but if I get everything lined up between the unparsed JSON and the inline styles and it’s still borked, I’ll reinstall my theme and or manually dump theme components from the database if needed (I think that’s what you’re pointing to with the unique ID bit).
Forum: Fixing WordPress
In reply to: Reference for block optionsHi @asifsiam97, close to the second case: I merely duplicated the theme, changed the directory name and all occurrences of
twentytwentyfourin the theme, and started modifying.Forum: Fixing WordPress
In reply to: Reference for block options@bvbaked Hey, thanks for the response. Regarding macros (I’m not sure if that’s the right term, but it does seem like some sort of macro replacement it taking place), if you look at any of the
.phpfiles inparts/orpatterns/, you’ll see a bunch of HTML comments that markup blocks. For example, in,<!-- wp:group {"align":"wide","style":{"spacing":{"padding":{"top":"var:preset|spacing|60","bottom":"var:preset|spacing|60","left":"var:preset|spacing|60","right":"var:preset|spacing|60"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group alignwide" style="padding-top:var(--wp--preset--spacing--60);padding-right:var(--wp--preset--spacing--60);padding-bottom:var(--wp--preset--spacing--60);padding-left:var(--wp--preset--spacing--60)">The first part is what I was referring to as ‘macro’. The options that are parsed from there are what I am looking for a reference for. The link you supplied is good in terms of listing a lot of the top level supported options, but it doesn’t give a full listing. For example, from inspecting, say, the Twenty Twenty Four theme, you can see that
"padding"is nested under"spacing"which is nested under"style", but"background"is at the top level. This does not reflect the structure of CSS and the inline styles in the following HMTL markup. So what I’m looking for is a full reference so I’m not sort of haphazardly swinging away at modifications and custom blocks, and not sure why such a reference isn’t obviously available if theming is traditionally such a big component of WordPress (I started back in the classic theme days).Forum: Plugins
In reply to: [Social Sharing Block] Add Threads to list of supported social media site@ndiego, I went ahead and submitted the PR with both
src/andbuild/so you can do what you want with it, but I verified expected functionality manually. Should pass CI. Changelog in readme.txt just needs updating.Forum: Plugins
In reply to: [Social Sharing Block] Add Threads to list of supported social media siteHi @ndiego,
Do you want me to commit and submit a PR for just the source and readme changes?
EDIT: To be clear, do you want me to commit the build as well?
Best,
Justin
- This reply was modified 2 years, 3 months ago by Watermark Branding. Reason: Clarification
Forum: Plugins
In reply to: [PDF Invoices & Packing Slips for WooCommerce] Incorrect discount on invoiceApologies Ewout,
To be clear, I did not use WooCommerce PDF Invoices & Packing Slips plugin on this particular site: the issue does seem to be with WooCommerce.
That said, if anyone has any advice and/or has experienced the same issue, please email me.
Best
Forum: Plugins
In reply to: [PDF Invoices & Packing Slips for WooCommerce] Incorrect discount on invoiceHey Jaap,
Did you ever sort this issue out? One of my client’s sites is having the same problem: correct discount total on back-end order, but incorrect on customer invoice e-mail. I too received the same, unhelpful responses from WooThemes.Thanks!