Forum Replies Created

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter webmaster128

    (@webmaster128)

    Hi BestWebSoft Support Team,

    sure, here you go:

    1. Adding class “cptch_task”

    In our case (https://kullo.net/blog/how-we-benefited-from-the-cebit-2014/) I had to do relative positioning between the label and the Captcha task to fit in the style of the theme (derived from Twenty Eleven).

    There might be other situations, where you want to be able to optionally access the Captcha task from CSS, like changing fonts.

    2. Move br into the if-block

    In case no Label-Text is set, there is no reason to follow <p class="cptch_block"> with a linebreak, e.g. <p class="cptch_block"><br />nine+9. This adds whitespace, that can not be removed via CSS.

    Hope that helps!

    Cheers,

    Simon

    Thread Starter webmaster128

    (@webmaster128)

    What I now use is the following pattern:

    @^[\r\t ]*https?://(?:www\.)?(?:(?:youtube.com/watch\?)|(?:youtu.be/))([^\s"]+)[\r\t ]*$@im

    This causes the same effect but is much more clean and intuitive since you don’t want to cut off the “\n”.

    Thanks and cheers,

    Simon

    Thread Starter webmaster128

    (@webmaster128)

    It turned out that TinyMCE in WordPress always saves linebreaks as “\r\n” no matter which OS the author is using.

    Thread Starter webmaster128

    (@webmaster128)

    Okay forget my first point. It works fine. I just don’t understand why it works

    Thread Starter webmaster128

    (@webmaster128)

    Hey devs,

    thanks for your fast reaction and support. I just installed the update.

    But I don’t get why you have the [\r\n]{0,1} around the regex.

    2 problems:

    The standard case

    Lorem ipsum a Lorem ipsum
    
    
    
    Lorem ipsum a Lorem ipsum

    still becomes

    <p>Lorem ipsum a Lorem ipsum<br />
    <iframe [...]></iframe><br />
    Lorem ipsum a Lorem ipsum</p>

    and [\r\n]{0,1} does not make any sense. It means: zero or one characters out of the set \r, \n. Thus a windows linebreak (“\r\n”) is not matched which means that the \r makes becomes useless.

    Cheers,

    Simon

    Thread Starter webmaster128

    (@webmaster128)

    Hi EmbedPlus-Team,

    thanks for your suggestions. I tried them and came up with a possible third option.

    Suggestion 1 – Surround output iframe with p
    Works fine, since WordPress sees an input like

    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsu
    <p><iframe ...></p>
    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum

    which is properly translated to three paragraphs. CSS classes are preserved as well, so you can have the following code in order to be able to style the Youtube paragraph:

    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsu
    <p class="youtube-embed"><iframe ...></p>
    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum

    This might be a possible default code.

    Awesome because:
    – $opt_center code can be included in the <p>
    – clean code in the WordPress editor

    Suggestion 2 – Hit Enter in the editor
    Works not so fine. Using your REGEX pattern, you eat up every whitespace around a Youtube link. This leads to the following code for WordPress to filter:

    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a
    
    &nbsp;
    <iframe ...></iframe>
    &nbsp;
    
    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a

    which then gets

    <p>Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a</p>
    <p>&nbsp;<br />
    <iframe ...></iframe><br />
    &nbsp;</p>
    <p>Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a</p>

    Not awesome because
    – 2 lines height space before and after the video
    – unclean code in the editor.

    Suggestion 3 – Stop eating newlines around link(My idea)

    The regex pattern
    '@^\s*https?://(?:www\.)?(?:(?:youtube.com/watch\?)|(?:youtu.be/))([^\s"]+)\s*$@im'
    eats up every whitespace around a link, including newlines.

    If you replace \s* with [ [:blank:] ]* (Remove space between [ and [, I have a ww.wp.xz.cn syntax problem here) the newline character is not included anymore. Thus an editor input like

    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a
    
    
    
    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a

    gets

    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a
    
    <iframe ...></iframe>
    
    Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a

    and then

    <p>Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a</p>
    
    <p><iframe ...></iframe></p>
    
    <p>Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a Lorem ipsum a</p>

    Awesome because:
    – doesn’t hack the wordpress paragraph logic
    – clean code in the WordPress editor

    Thanks for your offer. But before I try PRO I need a solid basic plugin πŸ™‚

    Best,

    Simon

Viewing 6 replies - 1 through 6 (of 6 total)