williampatton

I will test with Vivaldi browser and see if the results are different for me.

I repled to the screenshot email but keeping the conversation here as well for posterity. I would like to know if the issue is still detected if you scan the page from inside the admin editor instead of through the frontend highlighter. I have a theory about a possible cause which could help be confirmed if the issue is NOT detected when scanned from the editor.

@raygulick that’s what I expected about how you were running the scan. We were aware that the scanner could find this and we made updates to to account for it. I can’t replicate it on fresh install of the update however if the previous scan javascript file was cached on your server or in your browser that would explain this.

Do you have a caching plugin on the site? If so could you try to flush it and retest to see if the issue goes away?

Hey @raygulick,

Thanks for reporting this, the icon inside the widget is intended to be hidden from screen readers as it is a visual presenteation element only so aria-hidden is appropriate on that.

That being said it shouldn’t flag as a warning on your pages. I will see about getting that resolved.

Thanks for pointing out where you seen these. The ‘How to fix it’ does look like a string that we missed. The ‘Error’ and ‘Warning’ one though is a value that comes from the database which is why it wasn’t noticed.

These strings should be updated in the next plugin release to be translatable. Thanks for catching this.

Once I have the code done on my side and confirmed to merge for next release (probably tomorrow) I will mark this thread as resolved and let you know.

We do our releases roughly every 2 weeks. Typically on Tuesdays. Tuesday next week is our next release window.

And thank you so much for the offer of improved translations. I will keep an eye on glotpress and if you submit the improved strings I will backmerge them into our repo so they override our current ones.

Hi again @sfin100m

Since you have the pro plugin installed as well, it will be best if you contact support through the pro plugin and get into our normal ticket system. You should be able to get to the pro support form from the main plugin page in your admin.

Hey @bearblueberrypieyoda,

Thank you so much for using our plugin and sharing the feedback.

I totally get how ignores being reset would be frustraiting for you. That really shouldn’t be happening and I would like to understand why and try get a solution for that to you. Since this is a review, and not a support ticket if you want to dig in with me about that then openeing a support thread would be good.

You mention the ignore log – which is a pro feature. We can only discuss the features of the free plugin in these forumns however if you have the pro plugin you can reach out through those support channels and we can dig in there on pro features with you.

Hi Peter

I spent some time looking into this more yesterday and I can replicate what you see now.

In the past I have made the choice explicitly to test buttons for empty even when they are hidden via aria-hidden because interactive elements are still focusable even when they have aria-hidden assigned. I did not make considerations at that time for buttons inside containers that are hidden though.

I will look into what it will take to exclude those from inside hidden containers and decide if we do want to release that change (because in my mind checking contents that exists on a page and could have their visibility changed might still be better than missing potential issues if they are skipped due to initial state alone).

As an asside it might also be a good idea to consider an alternative lightbox script. Colorbox was arhived by the repo owner earlier this year and hasn’t had any update other than string fixes since 2016.