WowSoQuestion's Replies

Forum Replies Created

Viewing 3 replies - 1 through 3 (of 3 total)

Forum: Plugins
In reply to: [Simply Static - The Static Site Generator] Files contain 4 random hex characters

Thread Starter WowSoQuestion
(@wowsoquestion)

9 years, 1 month ago

I did some more digging and the problem shows up in the .tmp files which exist right after the call to wp_remote_get() and before the call to rename().

This problem is probably not scoped within this plugin.

Forum: Plugins
In reply to: [Simply Static - The Static Site Generator] ?attachment_id=NNN and Util::remove_params_and_fragment()
Thread Starter WowSoQuestion
(@wowsoquestion)

9 years, 1 month ago
As it turns out, that fix was not sufficient.

The real fix is to start from an unmodified installation, then in includes/class-ss-url-extractor.php add the following:
```
private function add_to_extracted_urls( $extracted_url ) {
                $url = Util::relative_to_absolute_url( $extracted_url, $this->static_page->url );

                if ( $url && Util::is_local_url( $url ) ) {
                        // add to extracted urls queue

                        // ::::::::: THIS LINE IS NEW :::::::::::::::::
                        $url = get_final_url($url);

                        $this->extracted_urls[] = Util::remove_params_and_fragment( $url );
....<snip>
```
The function get_final_url() was copy/pasted into the top of this file without any changes from this stackoverflow post.
Forum: Reviews
In reply to: [Page Speed Optimization] Does nothing that Autoptimize doesn't already do

Thread Starter WowSoQuestion
(@wowsoquestion)

11 years ago

If Optimalisatie.nl’s above response to my initial review is true, then other reviews citing a lack of documentation and/or poor usability are also true.

My initial review remains true to my experience with this plugin.

Viewing 3 replies - 1 through 3 (of 3 total)