wpthemesetcom

Forum Replies Created

Viewing 2 replies - 1 through 2 (of 2 total)
  • Forum: Plugins
    In reply to: [Post Types Order] Forced ‘orderby’ breaks WP_Query
    Thread Starter wpthemesetcom

    (@wpthemesetcom)

    9 years ago

    Hi there,

    I do agree with you, but my point is that a plugin should never impede the core functionality of WordPress to avoid other developers having to hack around said plugin in order to continue with the development process. It’s simply bad practice.

    Thanks

    Forum: Plugins
    In reply to: [Post Types Order] Forced ‘orderby’ breaks WP_Query
    Thread Starter wpthemesetcom

    (@wpthemesetcom)

    9 years ago

    Hi,

    Actually i’am not sure that will work, imagine if there’s an ‘orderby’ => ‘menu_order’ this will be ignored too.

    I would disagree with the above statement as I have just tested this and it’s working as expected. The suggested change means is that if there is a custom WP_Query and if that query has the parameter ‘orderby’ then use the custom parameter instead of the forced autosort.

    Your proposed alternative methods are also great, but it wouldn’t hurt to add a fourth option to ignore the forced ‘orderby’ just to avoid other developers from pulling their hair out 🙂

    Thanks

Viewing 2 replies - 1 through 2 (of 2 total)