yaronuliel
Forum Replies Created
-
Forum: Plugins
In reply to: [W3 Total Cache] [BUG] Wrong assumption for logged in cookie nameHi @vmarko
This is not exactly the same –Firstly, you have some places where the string
wordpress_logged_inis hardcoded, with no option to filter or modify via settings (e.g. here)Secondly, WordPress default behavior is not to use
"wordpress_logged_in"but to use the constantLOGGED_IN_COOKIE(which happens to have the default value wordpress_logged_in user – it sound similar, but it is not the same. Same way you shouldn’t hardcodewp-contentin your code base, but use the provided constants/functions to get the correct valueYou shouldn’t expect someone to install w3tc and think about whether someone has previously changed the values. Not only that, but it is also hard to track the issue, and people might easily get the production with it (I only spotted it after 3 days, since it needed to have a very specific chain of events for it to really matter in my case)
I still argue that this should be fixed in the plugin source, and should be treated as a security issue (information disclosure vulnerability).
Is there anybody out there?