amddtim
Forum Replies Created
-
Same issue as @gabeconnolly. The custom_args are not getting properly decoded when they get parsed. I don’t know when this started happening as I didn’t have the patience to pour through the git commits.
I added
urldecode($param)to theparse_custom_argsfunction on line 442 ofclass-alm-queryargs.phpand that fixed the problem, though I’m unsure of the wider ramifications of doing that. The PHP Manual entry on urldecode suggests that the$_GETvariable should already be decoded and that seems to be the ultimate source of the params, so I’m not sure why we need to do this again.Forum: Plugins
In reply to: [Grids: Layout builder for WordPress] Some suggestions+1 The zeroed values make it impossible to set actual defaults in the theme, defaults with the intent to get overridden on a section-by-section basis. If there’s no value provided in the section, the inline css variable declaration should be omitted.
+1 Please fix this PHP 8 deprecation
Forum: Plugins
In reply to: [Grids: Layout builder for WordPress] Section Background CSS SpecificityThis is still not scoped correctly in version >=1.3.0. We have the same issue with the css variables, that nested background pseudo elements look up the dom tree for the closest declaration of
--grids-section-background.Forum: Plugins
In reply to: [PWA for WP - Progressive Web Apps Made Simple] HMTL5 Video AutoplayLet me know if this works:
https://drive.google.com/drive/folders/1ayVpQa73h2PHW6-evYgEPiIZozVOU6pf?usp=sharing
Forum: Plugins
In reply to: [PWA for WP - Progressive Web Apps Made Simple] HMTL5 Video AutoplaySorry, I had to implement a quick fix on the live site because I couldn’t deal with the missing video. I temporarily told the plugin to bypass the cache for the video url, which is why you can’t replicate it now. It’s a temporary solution.
You can have a look at the staging site https://mattcstag.wpengine.com/ that’s doing the same thing. I think the issue is when a user doesn’t let the whole video play/load and navigates away from the page. The service worker saves a chunk of the video as a range request, but when a user returns to the home page, the worker is not able to play the video because it doesn’t have all the video data cached.
(btw, not sure how to share screenshots on here. But basically, the hero area is black, instead of playing a video)
- This reply was modified 5 years, 1 month ago by amddtim.
Forum: Plugins
In reply to: [Ajax Load More – Infinite Scroll, Load More, & Lazy Load] PHP 8Do you have logging turned on the the config file? I have lots of shortcodes/functions I’m using across several installs. Here’s an example of some code followed by an example of the notice.
[ajax_load_more id="speakers_carousel" container_type="div" css_classes="speakers-carousel slick-slider" theme_repeater="speaker.php" post_type="act_speaker" posts_per_page="999" order="ASC" scroll="false" transition_container="false" destroy_after="1" custom_args=“query_year:2020" cache="true" cache_id="2799722020"][18-Jan-2021 17:04:23 UTC] PHP Deprecated: Required parameter $args follows optional parameter $alm_found_posts in wp-content/plugins/ajax-load-more/core/functions.php on line 84Forum: Plugins
In reply to: [WebP Express] Can this plugin be used without .htaccess files?Bump!
Running into this issue now with WP Engine dropping support for .htaccess in PHP 7.4. They’ve been able to add Nginx workarounds, but as you mentioned, the WebP Express backend settings page still throws errors because the .htaccess files can’t get written.
Forum: Plugins
In reply to: [Grids: Layout builder for WordPress] IE11 CompatabilityHi Andrea,
Yes, that link has now been updated with my changes so it’s not a good illustration of the issue any longer. If you’d like, I can reverse the change for you to see it.
I’ll email you the suggestion, but for anyone else who landed on this page with the same issues, it mostly comes down to tweaks in Area.php and Section.php to get the -ms generated inline CSS more in line with the recommendations here. You can ignore the Autoprefixer stuff and just focus on the output. Specifically, you can’t use the
repeatfunction for grid columns or rows.The more hefty, eventual core update should probably use grid-template, since we also have a problem with IE11 not using grid gap. I went with a more hacky CSS approach (like how Bootstrap or Foundation build column gaps with flex and margins) for expediency sake. But that article I linked should give you all the ammunition you need to update this plugin.
And for what it’s worth, I have been very happy with this plugin otherwise! Definitely something that should have been in the WP block core in the first place.
Ticket opened.
- Turned off cache and removed the cache parameters from the shortcode
- Removed all ALM instances except for the quote block
- Added a
<div>wrapper to the entire quote block repeater template
Still getting the console error: http://actexpo02.wpengine.com/about
I don’t think it’s the ALM Cache. I turned that off locally and am still getting the same console errors. Also changed to
transition_container="true"andtransition="fade"on the quote section with no success.Let me know if you need any login access.
@dcooney shouldn’t be anything unclosed and the link is a staging site which doesn’t employ caching. Wasn’t working locally either. Hard browser refresh. Everything.
Out of 6 templates used on that page, they all through errors. Note that the content is actually served (some of the blocks hide it until slick.js can be fired), but the console reflects the errors and the ALM javascript callback functions aren’t firing.
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce Pull ConditionalThanks, I’ll go with that. I’ve been printing the results in a debug.log all along, which is how I saw what was going on.
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce Pull ConditionalSo if I’m trying to get the WordPress post id to either publish it or set to draft, is it best to use $result[‘data’][‘ID’] instead for the object_sync_for_salesforce_pull_success filter? Will that always be available?