Daniel Iser
Forum Replies Created
-
@nobo73 – Glad the errors are gone, I’m gonna be logging off for the night (very late here).
If you can follow the guide here, and send a token via the support form I will be happy to check it out tomorrow, otherwise maybe you can fire up one of our demo sites and set up a test there to duplicate the issue and I can investigate.@heartitwebdesign Patch available via v2.0.4
@heartitwebdesign – Sorry to hear that. I’m looking into how to prevent such an error, but in the mean time can you possibly test the Health Check plugins Troubleshooting mode on the plugin to see if the issue goes away?
If it does, can you then reactivate other plugins & themes a few at a time to see which one might be interacting with it?
I ask because the error indicates that some variable in the $wp_query args for your site has been replaced with a function instead of the value. Either its not intentional and we just happened to have the code that caused it to be a problem, or we need to account for that type of scenario if there is a valid use case.
Look for a patch shortly to address this.@spinozarabel – Awesome to hear, if you don’t have any further issues, please take a moment to rate & review the plugin to help spread the word.
@nobo73 I’ve been unable to replicate the errors on a clean install with that other plugin. The rules do show up properly and seem to work as expected.
– Do you only get errors in the front end, or also in wp-admin?
– Are you able to edit restrictions?
– Once you update and errors are suppressed, do the rules seem to work?
I’m wondering if they registered their changes later than we registered rules for some reason during one of the routines I’m not testing (before upgrading data, during migration).Update is available
@nobo73 Fix incoming, that is a different area of the same file, missed it first time. This time I searched all thrown errors and made sure they are either caught or not thrown at all.
v2.0.3 should alleviate that error. I’ll install the other plugin and test to see what I can do about that missing rule.
@spinozarabel Can you please update to v2.0.2 and let me know if that resolved it for you?
I’ll be online for a few more hours if your still having trouble let me know.
- This reply was modified 2 years, 9 months ago by Daniel Iser.
@spinozarabel – Sorry to hear that, I’ll work on a fix as quickly as I can, thanks for the heads up. Look for a patch very quickly.
Dug through everything:
– It should be noted the only way that rule could have existed previously is if you had modified your post type for pages and added tags. Possible with plugins.
– Is that still the case? Do your pages have tags now?
The rules are generated based on post types and the taxonomy attached to them in WP.
It may be that you previously had that and don’t now, which would allow for that rule to be added to a Restriction, but now isn’t available.
You might just try reviewing those restrictions and making sure your Content conditions are still valid.Keep me posted
One final question, have you already run the “Upgrade” for our plugin’s data?
I need to know if the issue comes from the upgrade, or the code that is in place before you run the upgrades to make sure old rules still applied.Ok very strange, do you happen to know what rule you had before,
pages don’t usually have tags, and it might have been a bug to allow that in the first place, now it tried to map it to something that doesn’t exist.If you can tell me the use case that enabled tags for pages I’ll see about making that a valid rule type.
@nobo73 Hmm, those appear to be built in conditions, but we thoroughly tested those transitions as we use it for multiple plugins, but maybe we missed something. It was a massive rewrite and its definitely possible.
Give me a few and I’ll see if I can patch that asap for you.Ahh ok that is definitely what it is. I’m gonna patch the code to not throw an error, but to log one instead in the plugin’s settings page which will tell us more about what it is.
Update to v2.0.1 which is available now, then load some front end pages and finally check the plugin’s settings page at the bottom. You should see a list of ERROR: Rule XYZ is not found or similar.Looking at just the line, is it possible you have another plugin on the site that is adding custom rules to our plugin? If so can you tell me which one so I can test with it.
Seems the issue is from registering rules, which would only throw an error if the rule came from custom code or another plugin doing it some way we weren’t expecting.
Might also be worth testing the plugin with the Health Check plugin’s Troubleshooting mode. It will activate only our plugin temporarily and let you activate others one by one to confirm where the problem is coming from exactly.