Paul

Interesting. If I get some time later this week, I’ll do a deep dive into our caching and your plugin to see where the problem is. It might be that our caching system is very similar to WP Engine’s caching system and they share a bug? If I find anything interesting, I will post it here.

No. We’re not on WP Engine. The client is on my hosting (Headwall Hosting). We’re running a memcached object cache.

Disabling the object caching in your plugin sidesteps the problem, but that doesn’t feel very robust. The problem is that get_atum_order_model() can return false|WP_Error|Object. If you had a check at the end of get_atum_order_model() like this…

if( !is_object( $atum_order ) ) {
   $atum_order = new WP_Error(........);
}

…that would keep things clean. Although the underlying problem seems to be that the plugin doesn’t work well with memcached? We don’t have problems using memcached on any other sites.

Anyway, for now we’ve just disabled the object cache option. The servers are fast enough that it works fine.

I hope this helps

Paul

I’ve posted the support request through your website contact form. I don’t have their order details because I just host the site (managed hosting). I’ve put some extra info in the email request for you, that might help.

Great, thanks for confirming.

Paul

Sorry for the delay – it’s been a busy couple of days.

By “redacted”, I just mean I removed some IP addresses and filesystem paths from the log.

When I investigate further with this patch in “ect-class-vc.php” (around line 26)…

if( is_array( $term ) && !array_key_exists( 'name', $term ) ) {
   error_log( 'FAIL: ' . json_encode( $term ) ); // << Added diagnostic info
} else {
   $ect_categories[$term->name] = $term->slug;
}

…I get this in the error logs…

PHP message: FAIL: {"invalid_taxonomy":["Invalid taxonomy."]}; PHP message: FAIL: []

So that’s two iterations of the foreach() loop where $term->name and $term->slug do not exist, which is causing an error in PHP8.3. One iteration returns some invalid taxonomy error, and the other iteration seems to have $term as an empty array? Weird.

Can you please just add some protection in the loop to check that $term contains valid data before you access the name and slug?

Thanks

Paul

I just tried the new beta version on one of my dev sites and I can confirm the Doing it Wrong warnings have been resolved 👍

I deactivated and reactivated the beta plugin and there is a Doing it Wrong warning in your activation action handlers somewhere, but the plugin looks OK for general usage now.

I’m happy to help with additional testing if needs be.