Jonathandejong
Forum Replies Created
-
Forum: Plugins
In reply to: [Revoker for WooCommerce] Withdrawal doesn’t go throughThis is a very real and big issue that you may want to address asap.
I did a deep dive test of this plugin myself and found the same issue. The problem lies in how you set up the logic around the plugin activation and creation of the custom database table. The logic is flawed in such a way that the table is never created.
Then, there’s no way to recover from that failure in the plugin either, so all that happens is that when attempting to create a withdrawal in any way (most commonly through the frontend on order page) this ambiguous error will occur.To be clear this error prevents anyone from using the plugin in its current version.
Forum: Plugins
In reply to: [Counting Number Block] It seems the delay feature is not workingThank you, that was a quick fix 🙂
Best regards, Jonathan
Hi!
Thank you for reporting this. I think the error is actually that for some reason the option don’t get loaded or you have never saved the settings and the plugin assumes it will exist as an array.Either that, or you have made modifications using the beautiful_filters_post_types and do not return an array to it but rather a string.
<?php
$post_types = get_post_types(
array(
'public' => true,
'_builtin' => false
),
'objects'
);
$activated_post_types = apply_filters( 'beautiful_filters_post_types', get_option('beautiful_taxonomy_filters_post_types') );
?>
<?php if($post_types): foreach($post_types as $single_post_type): ?>
// HERE IS WHERE THE ERROR OCCURS BECAUSE $activated_post_types is not an array.
<?php if(in_array($single_post_type->name, $activated_post_types)): ?>I’ve just pushed a new bugfix version 2.4.6 which should resolve this by both adding a fallback value to get_option and a type coercion into an array.
Still, I would suggest you check that you don’t use the filter and return a string.
Forum: Reviews
In reply to: [Beautiful taxonomy filters] Great pluginThank you @kerla !
I appreciate you taking the time to review. Knowing people find this useful is why I keep building it.
Forum: Plugins
In reply to: [Beautiful taxonomy filters] CURRENT STATUS – SecurityStatus update:
2.4.5 is out with some fixes to Select2 behaviour. Hopefully this release also gets recognised as a fix by the automatic tester systems. I’ve no idea why but for some reason they claim 2.4.4 still contained the security issue which is not true.
Forum: Plugins
In reply to: [Beautiful taxonomy filters] CURRENT STATUS – SecurityStatus update:
We are back folks! The plugin have passed the review and I encourage everyone to update.
One important note: In the process of updating the Select2 based dropdowns are experiencing a bug where clicking a dropdown immediately closes it again. So if you update to 2.4.4 you’ll want to disable the select2 feature.I am planning to get a 2.4.5 release out asap with a fix for this and plan to have that in place before the end of the weekend.
Thank you everyone for your understanding.
Forum: Plugins
In reply to: [Translation with DeepL API] Some issues with french and missing textsHi @malaiac , Thanks for the quick response.
Sorry to hear that Buddypress is giving you a hard time!
I thought it would maybe be related to when selecting specific languages to display as options.. but now when I go back to the same admin that I tested and this occurred on it’s “selfhealed” 😀
It’s back to just english now.
Just to show you what it looked like:
https://drive.google.com/file/d/10ZsrZjyhekvjGT_-NeWRoqqOWrjVKWIW/view?usp=sharing
https://drive.google.com/file/d/1e4NHUAZtsF_ainQmZPHbq374rSCx0hgv/view?usp=sharing
Forum: Plugins
In reply to: [Beautiful taxonomy filters] CURRENT STATUS – SecurityStatus update:
The plugin have been submitted for re-review with the plugin team as of version 2.4.4. The security issue has been addressed as well as all findings from the automatic tests run by the Plugin Check plugin.
Recognising that there’s some urgency to this update I’ve focused this release on just these issues so once it’s back, please do update as soon as possible to avoid exposing your sites.
I’m continuing to work on a larger overhaul of the codebase which will come later. I will take care avoiding breaking changes for everyone as much as humanly possible 🙂
Forum: Plugins
In reply to: [Beautiful taxonomy filters] PHP 8.3 WarningsHi Giannis,
Yes there is a planned rework of the codebase which would include support for PHP 8.3. I can’t give you a timeline of this right now however. In the meantime if you’re as sick of deprecation notices as I am you might want to make some noise in this PR: https://github.com/WordPress/wordpress-develop/pull/5494 (disclaimer that this is mine)
Forum: Plugins
In reply to: [Beautiful taxonomy filters] CURRENT STATUS – SecurityStatus update: I’ve addressed the security issues as well as taken the whole code base through a full audit using the Plugin Check https://ww.wp.xz.cn/plugins/plugin-check/.
I will inform the WP team as soon as I’ve got this tested to ensure that the functionality has not changed after making all the necessary changes.
EDIT: If anyone would like to help test this new version and are familiar with composer it’s possible to pull down 2.4.4 with the fixes using wpackagist as such:
composer require "wpackagist-plugin/beautiful-taxonomy-filters":"dev-trunk"DO NOT USE THIS IN PRODUCTION
The trunk version should be only for helping with testing. I cannot guarantee it will not crash your site until its been tested.Thank you for your patience
- This reply was modified 1 year, 5 months ago by Jonathandejong.
Forum: Plugins
In reply to: [Beautiful taxonomy filters] Closed/Removed – Anything we need to know?Hi @bncpeter 🙂 please see https://ww.wp.xz.cn/support/topic/current-status-security/
Forum: Plugins
In reply to: [Translation with DeepL API] Error: Parameter ‘text’ not specified.Ah, they were not! I’d recommend maybe adding a notice to the metabox or maybe improving the error messaging since these are also not toggled on by default when activating the plugin and are a bit down one of the settings tabs (easy to miss).
Enabling them fixes the issue.
Though shouldn’t it work anyway if I’ve enabled some meta with Pro?Forum: Plugins
In reply to: [Beautiful taxonomy filters] Uncommented error logHello tony Tigerton 😉
Yes of course, will remove that with an update!
Forum: Plugins
In reply to: [Beautiful taxonomy filters] Sticky PostsAlright well I’m glad you managed to solve your requirements either way!
I’m due for refactoring this plugin, the work has started, but it’ll take some time given other priorities.
For that reason, what would you say is missing from the plugin today?
More hooks?I know some “obvious” things like a block-based approach rather than widgets, update the design to fit the times etc.
Forum: Plugins
In reply to: [Beautiful taxonomy filters] Sticky PostsHi!
Apologies for a long overdue answer and I hope you managed to solve it!
But I think this is probably caused by the fact that BTFs custom archive URLs are essentially the “core” archive with lots of parameters that we use custom rewrite rules to make it look pretty.
So while it says /business-directory/location/london/ in the background it’s a URL like /business-directory?location=london
So I’m betting that the third party plugin you use to work with these sticky posts don’t actually use the query parameters to determine what taxonomy or term is shown, but rather goes by the core built-in functions like
is_archive()andis_tax(). Which isn’t wrong in itself! But it probably means it won’t work out the box with BTF.Unfortunately I don’t think there’s a whole lot that I can do in BTF to help with this.. unless you have found something? If you are capable of a bit of coding you could probably do some custom checks using the
pre_get_postsfilter to supress sticky posts where you want to.https://developer.ww.wp.xz.cn/reference/hooks/pre_get_posts/
Best of luck!