oolongm

I’ve changed the command pattern a bit, as this seems more intuitive, and also allows for multiple option updates in one line:

rsssl update_option --dismiss_all_notices=true

Thank you so much for adding this, however it doesn’t seem to have any affect for me on the popup that comes after first login and the notices that show up. Is it supposed to let this all disappear?

This will be included in the update next week.

I just tested the latest release (6.1.1) and it seems like there is a regression for the ssl activation. It still says “Success: SSL activated successfully” in the console, however in the wp backend it says “ssl not activated” :/

Now the new thing is that if I run the activation command a second time, it seems to work. Also if after the first (failed) attempt, I uninstall the plugin with the option “Delete all data on plugin deletion” activated – and then I try the whole process again it seems to work on the first attempt.

Any ideas about this?

I have created a branch that includes this fix, and also some logging in case there’s something else as well: https://github.com/Really-Simple-Plugins/really-simple-ssl/tree/logging-for-wp-cli

@rogierlankhorst I can confirm the ssl activation works again on this branch. Thanks a lot for finally fixing this. I’m looking forward to have this released, so our custom wp installation routine will succeed again.

As for the notifications: we try to balance between upsells and offering a great free tool without too many notices.

I understand that you need to make some money too, maybe I was a little too harsh with my criticism out of frustration with the wp cli activation not working.

My problem with notifications may be specific to our use case, because sometimes I set up batches of 30 or more WordPress systems at once. When each installation brings 5 notifications that need to be dealt with, you can perhaps understand how annoying they become.

Now, one could argue that we should just buy the Pro version (assuming that the notifications will go away in this case), but unfortunately we already have another plugin with similar security features in use, so we don’t really need it.

Maybe you could consider a wp cli action to disable notifications for power users. If not, I guess we just start living with them, just like the other hundred notifications we see from other plugins :p

Anyway, although the code changes took several attempts to fix the problem, I am very pleased with the response times of your support and the detailed explanations you gave. That’s why I changed the rating to 4 stars. I will also gladly change the rating to 5 stars another time if you do find a solution to our notification problem 😉

I can confirm the language issue is gone in the latest version.

The cli activation however still doesn’t work. You really don’t have a system where you could test it?

PHP Fatal error: Uncaught Error: Call to undefined function rsssl_uses_htaccess() in /public_html/wp-content/plugins/really-simple-ssl/settings/config/disable-fields-filter.php:10
Stack trace:
#0 /public_html/wp-includes/class-wp-hook.php(308): rsssl_remove_fields(Array)
#1 /public_html/wp-includes/plugin.php(205): WP_Hook->apply_filters(Array, Array)
#2 /public_html/wp-content/plugins/really-simple-ssl/settings/config/config.php(1109): apply_filters(‘rsssl_fields’, Array)
#3 /public_html/wp-content/plugins/really-simple-ssl/settings/settings.php(536): rsssl_fields(false)
#4 /public_html/wp-content/plugins/really-simple-ssl/class-admin.php(356): rsssl_update_option(‘redirect’, ‘wp_redirect’)
#5 in /public_html/wp-content/plugins/really-simple-ssl/settings/config/disable-fields-filter.php on line 10

• This reply was modified 3 years, 5 months ago by oolongm.

Thanks for this super fast reply! I’ll try it soon, next time I’ll setup some new sites. But the code looks like it should solve the problem.

As you can imagine, we did not code our plugin to delete your images on purpose, so we would’ve appreciated if you could’ve sent us a short e-mail telling us about the issue so we could fix it, instead of writing a 1-star review straightaway. I can assure you that our priority is for our clients to be satisfied.

My intention was to do a bug report and to warn other users in the same time. Once this is fixed, I’m happy to reconsider my rating.