pilam
Forum Replies Created
-
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] sp_shortcodes_button errorHi @savvasha,
Sorry for the delay in getting back. I have a lot more plugins I use and I was trying to eliminate as much as possible by doing a fresh install myself. That didn’t give me any clues but then I noticed that the problem only occured when opening an existing popup to modify it. If I added a completely new one it worked fine.
I then realised that those popups which had the problem all had classic blocks in them, i.e. the Classic Block formatting in Gutenberg. Remaking those blocks as ordinary Gutenberg paragraphs or similar eliminated the problem completely. (Adding a classic block brings it back though!).
So I still don’t know what actually caused the problem, but as long as Classic Block formats within Gutenberg aren’t used, the error doesn’t appear.
Again, sorry it took so long, but this can be closed from my perspective.
Thanks,
Pilam.
Hi @dudo ,
Thanks for getting back so promptly. I’d already opened a ticket at Sportspress and the suggestion was to check here as the error only occurs when I’m using YASR 2.3.3. But I do now notice that it appears even when the shortcode is not in the post, which is somewhat bizzare.
I’ve gone back to Sportpress with your feedback so we’ll see where it goes from here. In the meantime, is there anything you can think of off the top of your head which changed between 2.3.2 and 2.3.3 which might give a pointer?
Many thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] sp_shortcodes_button errorHi @savvasha,
I’ve done that:
https://ww.wp.xz.cn/support/topic/2-3-3-upgrade-problem-with-gutenberg/
and YASR’s author appears to be able to recreate it with YASR disabled, although that is the only trigger I’ve discovered so far. However I can confirm what he says about the error appearing even when the shortcode is not in the post – the same happened to me.
Something is trying to initialize the plugin when Gutenberg is enabled, even when it is not in the post.
HTH,
Pilam.
Forum: Plugins
In reply to: [Modula Image Gallery - Photo Grid & Video Gallery] Can’t close lightboxJust a quick follow-on. The reason I couldn’t see it was because it was hidden behind the admin bar. So it’s no problem for users/visitors.
Thanks again.
Forum: Plugins
In reply to: [Modula Image Gallery - Photo Grid & Video Gallery] Can’t close lightboxD’oh, it’s there! Really sorry about that – don’t know how I missed it. Reckon I’ll have to make an appointment with my optometrist when lockdowns are lifted.
Sorry to have bothered you, and thanks for a really quick response.
Pilam.
Forum: Plugins
In reply to: [All-In-One Security (AIOS) – Security and Firewall] Disable Right ClickHi @mbrsolution ,
I was afraid that would be the answer! Thanks for responding so promptly anyway.
Regards,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Event Preview & RecapHi @savvasha,
Almost.
You’ve changed it so that it works correctly for postponed or cancelled events, but it should be the same for all events. IMO it should be a simple test, independent of whether the Event has been postponed/cancelled:
Is the current date/time before or equal to the Event’s Published date/time? Yes = Preview, No = Recap.
However, if you wanted to get the terminology strictly correct, the test would be as follows for all Events:
Is the current date/time before or equal to the Event’s Published date/time? Yes = “Preview”
Is the current date/time after the Event’s Published date/time and Event Details have been added? Yes = “Recap”, No = “Summary”
“Recap” should only be used when the Event is over, i.e. completed. Doing it in this way would also help so that if it said “Summary”, the Event was still waiting to have its Details entered.
Sorry its a long explanation, but the nuances of the words Preview and Recap make it complicated!
Thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Event Preview & RecapHi @savvasha,
OK, I see what you mean. I think we’re talking at cross-purposes though, because that’s way too complicated a solution to what is basically a simple problem.
I’m not looking to add any more detail or anything like that. It’s simply the erroneous use of the word “Preview” when looking at the detail of a past Event. By definition, a Preview happens before an Event. Displaying something as a “Preview” after the Event has occurred is an oxymoron.
It might just be a misunderstanding of the meaning of the word if a non-native English speaker did the original coding. It doesn’t make sense to a native English speaker.
Anyway, I’ve found an alternative solution. I’m doing away with “Preview” and “Recap” in the Text Settings and calling everything “Details”. It’s not ideal, but it makes much more sense than the current language.
Thanks for your help with this. I’m sorry it took up so much time, but I would urge you to consider changing the code as I suggested, as currently it is semantically incorrect. Users think something’s wrong with the site when they see that.
Thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Event Preview & RecapHi @savvasha,
I’m not clear on what you mean. Is the suggestion that I create an additional Event for each match and link to it from the original match? Forgive me if I misunderstand, but I don’t see how that would work.
I tried creating a link from the Event description to a new page called “Cancelled” but unsurprisingly that had no effect. Somewhere there is a trigger which causes the displayed heading for an Event’s article to change from “Preview” to “Recap” in the Event View, and this happens ONLY after Results have been added to the Event (in my installation that means players results being entered). It should just work as you mentioned in your first response – when the date of the Event is passed. But it doesn’t.
I trust we’re on the same page here. My premise is that “Preview” implies that the Event has yet to take place. “Recap” implies that the Event has taken place. It should be totally date driven – not reliant upon results being entered. That’s the way it works in the widgets, but it’s wrong in the Event View.
Thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Event Preview & RecapHi @savvasha,
Unfortunately it doesn’t if you don’t have any results added – which will always be the case when an event has been postponed or cancelled.
Here’s an example of a past, cancelled event showing in the Event List widget. This displays correctly, as it says “Recap”.
Then when you click on that Recap link and are taken to the Event detail, it reverts to Preview, not a Recap. This only happens when there are no Event results added, which would be the case with a cancelled Event. For the Event detail it appears that Event results are the dependency, not the date.
Rephrasing Recap in the Settings isn’t a workable solution, as that would change it everywhere and this is the only place I’ve found where it happens.
Thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Postponed Events 2.7.1Hi @savvasha,
Yes, that looks ideal (if my rusty coding ability is anything to go by!). It’s a good solution as most of the time this is a rare requirement – hopefully – and including it in the widget is the most elegant solution.
Many thanks,
Pilam.
Forum: Plugins
In reply to: [SportsPress - Sports Club & League Manager] Postponed Events 2.7.1Hi @savvasha,
Yes, that is what happens; I’m sorry if I didn’t explain the problem more clearly. I meant to refer to the Countdown widget which shows the next event. If the next event is postponed or cancelled it doesn’t appear in the widget.
I use that widget to prominently display the next event. Now it just shows the next scheduled event. I’m looking for a way to have the option of displaying the next event whether it’s been cancelled/postponed or not.
In actual usage it probably depends on what the event was. If it was just a run-of-the-mill match then it’s probably fine if that “disappears” into the Calendar List. But if it’s an event which, say, people have paid to attend, I need it to remain (effectively highlighted) on display with the added information I would add about postponement/rescheduling/refunds, etc..
I’m guessing that probably means a toggle field in the Countdown widget, or on each event, to make it work in this way.
Forum: Plugins
In reply to: [Compliance by Hu-manity.co] Button Text changes after update..I have the same problem with the colour change (it also affects the [cookies_revoke] shortcode). I don’t use multiple languages. Can you explain further what you think the problem is/was? Has the colour change reverted to the original after you fixed the language problem?
Thanks.
OK, got that working now thanks, although the formatting is not quite there yet. I’ll wait until the update in a couple of weeks and give it a fuller test then.