Tim Eckel
Forum Replies Created
-
Forum: Plugins
In reply to: [Minify HTML] split options “Remove HTML, JavaScript and CSS comments”Unfortunately, it’s all or nothing.
Forum: Plugins
In reply to: [Minify HTML] split options “Remove HTML, JavaScript and CSS comments”If you don’t want to remove code comments, simply turn off that option. It doesn’t seem required to make it 3 options for your one use case when no one else has ever had an issue.
Forum: Plugins
In reply to: [Minify HTML] Minify HTML per pageNo, it can’t be disabled per page. I would try changing the setting to see if there’s a particular setting causing it.
Remove relative domain from internal URLs is set to OFF by default, so your fears are unfounded.
I’ve never used OGP tags and probably others as well. There’s other situations where a setting causes a problem. The solution, instead of trying to make unique solutions for every possible 3rd party tool or plugin, it so simply create a switch to turn a certain feature off, which is currently implimented. The complexity is the need for every other unique case to also be addressed, not just OGP tags (that’s just one of many).
The solution is to simply turn off remove relative domain from internal URLs.
@frkly Resolved in v2.1.12
Good catch, I’m not using 8.1 and didn’t know this was deprecated. I’ll look into this and resolve the issue. It is just a warning, so it continues to be operational.
The plugin shouldn’t be making specific exceptions for a product or service that doesn’t support relative URLs. Also, only doing relative URL conversion inside of certain tags would require a heavy-lift.
Instead, the solution is to simply turn off the Relative URL option. That’s what the option is for, if you need the full URL, just turn off this option.
Forum: Reviews
In reply to: [Minify HTML] Not WordPress friendly 😁It’s not a bug and it doesn’t “break” CSS style. What it does is uncover assumptions made in style that rely on white space, which could be considered template debugging. From the plugin documentation FAQs:
Normally, you won’t notice any changes to the way the site looks in the browser. However, if you rely on white space between HTML tags (which you shouldn’t be doing) you may notice very isolated elements with reduced horizontal spacing. This is because inline objects will add a few pixels of spacing if there’s whitespace between the objects. I consider Minify HTML a good way of finding these style ‘errors’ and correcting them with proper padding or margin style.
So what you consider a bug, I consider a feature to expose style bugs.
Forum: Plugins
In reply to: [Minify HTML] Incompatible with GravityForms – solution available@rmpel A new version was released today which may resolve this. It doesn’t specifically target this fix, but I believe it’s related and could resolve this problem as well. I don’t use GravityForms to test it.
Forum: Plugins
In reply to: [Minify HTML] Saving a post in WP 6.4 converts content to Classic block@villekautto @jirsbek @byothe @gringopost @sujaljain007 @hgaugenot
New version released which should resolve this issue.
Forum: Plugins
In reply to: [Minify HTML] Not compatible with latest WP version.@consensusb Unfortunately, WordPress uses Subversion, and doesn’t really allow for repo collaboration. If you have a suggestion, please post it here. Also, a new version was just released today.
Forum: Plugins
In reply to: [Minify HTML] Saving a post in WP 6.4 converts content to Classic block@jirsbek Thanks.
Forum: Plugins
In reply to: [Minify HTML] Saving a post in WP 6.4 converts content to Classic block@jirsbek Could you supply the first section of the code you’re using? What I’m unclear about is if you keep the following part or not, as that will also call the
teckel_init_minify_html()function:if ( !is_admin() ) {
if ( !( defined( 'WP_CLI' ) && WP_CLI ) ) {
add_action( 'init', 'teckel_init_minify_html', 1 );
}
}Forum: Plugins
In reply to: [Minify HTML] Saving a post in WP 6.4 converts content to Classic block@gringopost Are you also removing this part of the code in the plugin?
if ( !is_admin() ) {
if ( !( defined( 'WP_CLI' ) && WP_CLI ) ) {
add_action( 'init', 'teckel_init_minify_html', 1 );
}
}As if you’re not, it’s calling teckel_init_minify_html() twice.
Forum: Plugins
In reply to: [Minify HTML] Exclude canonical from relative URLGot it. The added cononical tags would kind of defeat the purpose of MininifyHTML. Turning off the setting which removes the protocol and domain from links would be preferred. That’s why there’s an option to turn it off. If you feel you don’t want links changed to relative.
Also, Google does say “relative paths are supported by Google” in regards to cononical links. The suggestion not to use them is if in case you exposed a testing domain to the search engine. This should be made physically impossible anyway, so using relative paths with cononical links isn’t a problem anyway. Sounds like an overzealous warning, I’d leave relative links on.
- This reply was modified 1 year, 8 months ago by Tim Eckel.