Daniel Iser
Forum Replies Created
-
Wow, sorry about the terrible grammar
be lSorry, was on my mobile trying to get responses out quicker.For more clarify, this error seems to indicate our upgrade ajax request handler either errored during your upgrades, or is still actively being run be at times it shouldn’t.
Can you expand on the exact series of events and order. Are you still seeing new errors or are you only seeing them from the time when you ran the upgrade itself?
Need to narrow down as much as possible when/where in the process things might be going wrong.
—
That said if you are not actively seeing new errors, and your restrictions are working correctly, you are likely safe to proceed as you were, but I’d love to solve this for possible future upgrades just the same.
@junxiu6 We have a tool that lets us test various states and transitions for the upgrade process. Built it to try and not have any of these issues.
But I have tried both with the tool and manually and cannot replicate that specific issue.
Would it be possible to get access to the site or a staging site to see the issue and troubleshoot?
That said, are you also saying downgrading, then upgrading worked fine after?
@chezterman be lSorry to hear that. Would it be possible to get access to a staging site to try and work out how that is happening?
we have one other report by this far have not been able to duplicate the issue.
@thomascharbit – Sorry to hear that, this function seems to be problematic when it shouldn’t be.
- I just added an early bail to restriction checks for WP CLI, sorry didn’t see that coming.
The function in our code in question isis_frontend()and checks a bunch of WP things such asis_rest(). But because that can run on any WP_Query call, to filter restricted posts, somehow it sometimes gets called before $wp_rewrite is ready (plugins_loadedis the only hook I’m aware of, and shoulnd’t be used for post querying really, but what can we do).
v2.0.10 will have the CLI fix I believe that should help with your commands. - I also made our query filters not run prior to plugins_loaded 9999999 which hopefully means everything is done by then, if not try this filter:
add_filter( 'content_control/query_filter_init_hook', function () { return 'wp_loaded'; // Try setup_theme, after_theme_setup, init or wp_loaded } );Look for v2.0.10 tomorrow some time. Keep me posted.
@nikhilranpara-1 – Yes, that is quite old, though at first glance the versions looked similar, it was in v1.8.12, we are on v1.18.2, lots of releases since then.
Here is the changelog in question, patched and released days prior to that publication: https://github.com/PopupMaker/Popup-Maker/blob/master/CHANGELOG.md#v1813—10112019https://github.com/PopupMaker/Popup-Maker/commit/974f6f395d052db4b493d616130b4538f9ffcdfd
You will still get a curl response from those requests, but it will be the WP permission denied or login screens. They all require a valid nonce after that patch.
Hope that helps. Let us know if there is something we are missing.
@junxiu6 – do you use browser extensions of some kind that may be blocking things from loading? Just to be sure, you can try in a private browser session (usually they are without extensions).
Also with the health check plug-in active you CAN activate troubleshooting mode. Activating the plugin itself won’t do anything helpful.
with it active go to the Plugins page and next to Content Control you will see Troubleshoot.
Click that and see if the issue is still occurring. If so then you can activate other reenable other plugins a few at a time and retest. When you see it break again one of the last plugins you enabled will be the one we need to investigate.
@tcleatherpenguin – Sorry to hear you didn’t find everything you needed.
That said can you elaborate a bit? Exactly what kind of control do you feel its missing.
We always are looking for improvements, with the final release of v2.0 this past week we added a ton and improved a ton more. This was a complete rewrite taking nearly a year.
@nobodee – Hope all is well. Let us know if your still having issues or if the fixes we pushed helped. Would love to get your review restored :).
@dkurapati – Haven’t heard from you in a while, gonna mark this closed. If you are still having trouble feel free to mark this unresolved again and update us on the status.
Otherwise please take a moment to rate & review the plugin and or support to spread the word.
@lewisburgess79 – If your still having issues feel free to mark this as unresolved again.
If not please take a moment to rate & review the plugin and or support to spread the word.
@nobodee – Gonna close this for now, if your still having trouble just change it back to unresolved.
@junxiu6 – Hmm, that shouldn’t be possible, but I’m happy to try and help.
From the message it seems WP scripts are not loading specific wp files that we depend on, but if they weren’t available WP usually would prevent our code from loading as well. Clearly ours is there, so WP thinks the others are too.
What version of WP do you use?
Can you install the Health Check & Troubleshoot plugin, then use the Troubleshooting mode on just our plugin to see if the issue goes away? If so activate the other plugins one at a time until it comes back so we can find which one is conflicting.
@gerold1968 – Ok I’m looking to get a copy of that plugin now, if you can send it via the support form on our site that would be helpful, otherwise I’ll track it down.
Did your restrictions begin working correctly as well once that code was added?
@lukiano880 – Hmm, I was testing with ACF on a separate issue the other day, can’t say I ran into this but I’m happy to help.
The first thing to do is check your Content Control logs, available on the settings page). If you see missing rule notices it likely means something on your site is running post queries before your post types are officially registered. Since we filter post queries, this is forcing our rules to be generated before your types are ready.
You can try this fix here, which will prevent our query filters from running until much later. If you don’t see any adverse side effects its probably safe to leave it.
That said I’ll do some digging and see if maybe there is a more elegant solution.
add_filter( 'content_control/query_filter_init_hook', function () { return 'init'; // Try setup_theme, after_theme_setup, init or wp_loaded } );- This reply was modified 2 years, 8 months ago by Daniel Iser.
@ogagliardijr – Sorry to hear that. It sounds like your having a different type of issue and should probably start a new thread, but while your at it, go ahead and use this guide on that empty page as you likely have a JS error in your admin of some kind: https://docs.wppopupmaker.com/article/373-checking-javascript-errors
@rogererkens – Keep me posted.
- I just added an early bail to restriction checks for WP CLI, sorry didn’t see that coming.