Daniel Iser
Forum Replies Created
-
@ronstallmach – Further proof, I just tested this plugin: https://ww.wp.xz.cn/plugins/login-sidebar-widget/
It works within our messages.
Definitely something weird happening, but I’d need a copy of that plugin your using.
Feel free to submit a copy at https://contentcontrolplugin.com/support/
@ronstallmach – Hmm, I just set up a simple test, the shortcodes get rendered in that area, I’m wondering if its something else.
Easiest test was [video src="youtube link here"]. The player renders on a page, and the shortcode gets rendered as a link in the replacement content.
So there is something going on, but its not that shortcodes aren’t rendering.Looking into it further
@gerold1968 – Hmm, I went through and the only time those things are called is during the upgrade in the admin. I can’t see how it would be run on the frontend at all, and shouldn’t be running in the admin either.
Did you already open an email ticket and submit a login token? Would like to see if I can work out what is happening.
@noelawill – Typically the error logs would be on the host/server. See if your hosting dash offers them.
@ronstallmach – To confirm, are you saying in the new version, the shortcode isn’t getting rendered?
If that is the case (inspecting now), I’ll try to get a patch out quickly.
@lewisburgess79 – Sorry to hear that. Can you give me an idea of how you are using them? I ask because you mentioned “making new lines” was undesirable, I’m assuming you are using them inline with other text surrounding them?
I just want to be sure I’m solving for the right issue.
In any case I just checked the old and new and the only difference appears to be that we added an extra class. No new div, the div was always there.
So unless you have CSS on the page that targets those classes, or maybe some new theme CSS that makes all
divrender as blocks, nothing should have changed:@stoffb – Grr, sorry to see that still. Can you possibly test this fix I just made. I see why it throws errors pretty clearly now, would like confirmation while I fix a couple other open issues.
The fixed line in question( ignore the comments ): https://github.com/code-atlantic/content-control/commit/dcb8857ed2de9dc2ec667bbaaa55e42ae37938b2#diff-9bef2d0f0d25cb707e140e26d774ef83f181e5b0d349f24845ad6c314f9ad86eR157-R158- This reply was modified 2 years, 9 months ago by Daniel Iser. Reason: Fix link
@nobodee – Rest assured, my goal since v2 released was to quickly iron out all the kinks, fix any integration issues etc. We will get to a stable place very quickly, but v2 was a complete rewrite, and we tested for months without issues, though we can’t test with every combination of WP plugins.
@gerold1968 – Are you seeing these everywhere, or only in the admin, or only when running our upgrades? Any extra info would be helpful. I’m about to push a large set of small changes meant to make things more strict in our code, and have patched about 7 other known reported issues so this might have been resolved already.
Also from the looks these were during an upgrade. If your done with the upgrade you might likely not ever see them again anyways.
If your not seeing them any longer lets go ahead and mark this resolved for now.
@noelawill – Without errors its is impossible to know if we solved it or if we are even looking in the right place. I have patched quite a few over the past 2 days and have a large patch coming, but your fine to sit it out for a few more versions as we iron out the inevitable kinks of a complete rewrite.
I will say we tested for months and have been implementing tooling to try and catch as many issues before a release as we can. Can’t account for everything unfortunately in the WP ecosystem.If you can provide some details on how to duplicate this or what the errors were please re open this thread or start a new one, but I’m gonna mark it closed for now so that we can focus on resolving as many issues as we can and you can update at a later time when you deem it safe.
@davecarpenter – Sorry to hear that. I’ve got this on my radar to handle this week. Let me make sure the random upgrade & fatal errors are dispatched and I’ll definitely look at optimizing it with you.
I’ll test your solution is suitable for our needs, we can also add optional caching parameters which we currently don’t to provide live search.
Feel free to open a PR or github issue otherwise I’ll circle back shortly.
@nobodee – Sorry to hear your having trouble. Happy to try and help. You can always download older versions on the Development tab of the plugins page here on ww.wp.xz.cn.
Can you tell me what exactly broke. Are the posts not restricted now at all, or the excerpts are behaving as expected?
Can you also tell me if it is broken on both single restricted posts & archives containing them?Can you provide some details on your current settings (in the new editor)? There were some new settings added that may be impacting your experience, want to make sure its optimized for what your wanting.
@stoffb – I think I have this patched, look for it in v2.0.7. Will push it shortly
@tylkoalibi – We do include the trusted login library (See Settings -> Content Control -> Support -> Grant Support Access).
If you have not used that feature yet, I’ll speak with them to see if its necessary to create logs before its used.
@nobo73 – Ok, If you have an email ticket in, I’ll definitely get to it if I haven’t responded already. In which case I’m gonna mark this topic resolved here and keep the email thread open to start consolidating the conversation.