Daniel Iser
Forum Replies Created
-
@ganimedeviaggi – Not sure how its breaking your install, the language pack installation, management & translation is all entirely handled by WordPress core, not our plugin and we use a different
text-domainwhich should prevent conflicts with strings overlapping.What type of breakage are you seeing exactly?
Also is the breakage only on the front end? If so it might not be our plugin causing it, but rather something you have inserted into a popup that is causing it.
Quick test in that case to confirm we aren’t the issue would be make a new blank popup with no targeting rules, disable all other popups. If the issue is gone the content of one of your popups is the cause.
Track it down by reactivating the other popups one by one til you find it.@theonebeautyla, @wmcd85020 , @mlchaves – Luckily I had patched to use the new WCAG
aria-modalattribute in1.18.0which was going out today already.Update, clear caches and retest. We no longer use
aria-hidden.@dylanfitzger – There are no forward facing alert banners, so I would have to assume one in the admin, but none of those include personal or identifying or even secure information other than possibly total popup views if it was a review request.
Happy to investigate but I’ve searched every usage of
$_REQUEST&$_GETin the plugin and none should result in anything like your suggesting unless there is a side effect I’m not seeing by looking at just the code.Only other thing I could think of was if you had a popup that had all the info your saying leaked in it, and didn’t secure that popup to only show to logged in users etc you could have leaked your own data, but then that would also mean that you are saying the parameter you added triggered the popup automatically, which is a built in feature, so not unexpected.
Email us if you feel its an issue we can get it worked out.
@1manfactory for clarity we are patching the second, but the first is not for our plug-in, but I’m assuming that was a mistake to report woocommerce issues to our team. Probably should tell them to fix it if you still need.
Take care.
@aryanrajseo will have a look, gut says one or the other needs to be refactored to change the post type slug from
popupto something prefixed. I’d much prefer the late-comer (them) to do that as there is less chance for breakage, but my guess is they won’t. I haven’t even contemplated what the impact of that could be on 3rd part code integrated with our plugins would be at this time, so its hard to say we could realistically change it on our end without a long term plan with multiple backward compatibility layers.@jordanek – Read what exactly? You didn’t actually say anything remotely useful for our team or any other users potentially looking at the plugin.
Further you literally created an account to write that review, and have posted nothing since.
Leads most to believe this is not an honest review. To each their own, but your review lives up to its title.
@dualaudi – Sorry to hear that, but a few things to consider.
Our CSS/JS is pre-minified and pre-combined into a single .css & .js file that is saved only when you make changes, even when you have all of our extensions installed. We have done this “AssetCache” for many years now. Those files are not very large at that. These assets are also friendly to plugins like WP Rocket, which we also use ourselves.
Second we run only 2 queries on the front end of your site, no matter how many popups you have. And if you use query/object caching, that goes to 0 queries.Lastly 100 empty popups would add no discernable difference to page loads because the popups are nothing but a few divs and a close button.
However the content you add to the popups can definitely impact load times, but that isn’t something we can do much about on our end, though we do provide tools to minimize their impact already:- Targeting rules can be used to limit which pages each popup appears on. If you have popups with media (images/iframes), and no targeting rules, they will load hidden on every page, even if they aren’t used. This is the default because the bulk of our users initially used the plugin for opening popups/modals from main menu items, thus it needed to “just work” on every page by default.
- Some content can be loaded on demand using solutions such as our Remote Content extension, but not all content can be loaded on demand such as form plugins. None of the currently available form plugins would work unless they were preloaded on the page which is how it works now.
- Content you add to popups can itself load additional CSS & JS assets.
Example, if you have 30 popups, with forms/images/iframes in them and none used conditions, then you can see how there would be performance penalties with all that extra content loading on every page.
There are other things that can have impacts as well, but this covers most cases. Without a link to the page specifically its hard to say for certain.
Hope that helps, and hope you can reconsider that 5th star. In reality we have optimized our plugin as much as is reasonably feasible as you can see, the way its implemented & the other plugins you use in combination can have undesired effects though if not considering the above possible impacts.
@rrank444 – This should be resolved in 1.17.1 update.
Hope that helps.
@brianrshim – Sorry to hear that. It might be best to submit an email based support ticket as we may end up needing to investigate the issue directly if it is possible to get temporary admin access. I have not seen this before so I’m not quite sure what exactly is going wrong.
@lstrand – Thanks for the report, fix released in 1.17.1.
Hope that helps.
Forum: Plugins
In reply to: [User Menus - Nav Menu Visibility] Notice Keeps Coming Back…Is it possible to get a screenshot? I’m not quite sure what notice that could.
@noelawill – Sorry for the delay.
Ok so this is the code we use to redirect a page that they don’t have permission for.
https://github.com/code-atlantic/content-control/blob/master/classes/Site/Restrictions.php#L30-L34
You might be able to hack that into a filter of whether the form should render or not, but I’m honestly not sure how to tie that to the form post type properly so my guess is that directly wouldn’t be the solution.
That said if you made a new restriction that didn’t target content, but set the user permissions properly, you could theoretically duplicate our restriction check code, choose that restriction by index and skip the “content_check”
https://github.com/code-atlantic/content-control/blob/master/classes/Site/Restrictions.php#L48-L67
$restrictions = JP\CC\Options::get( 'restrictions' ); $restriced_content = false; if ( ! $restrictions || empty( $restrictions ) ) { return $restriced_content; } // first one in list I believe currently, in future they will have actual IDs. $restriction = $restrictions[0]; $is_restricted = \JP\CC\Is::access_blocked( $restriction['who'], $roles, array( 'context' => 'content_restrictions' ) ); if ( $is_restricted ) { // do stuff or don't. }Hope that helps, you’ll have to hack it into your stuff from there, but it should work in theory.
Forum: Plugins
In reply to: [Performance Lab] PHP Error Cannot use object of type stdClass as array@jamesosborne – Thanks for the heads up, already installed and don’t think we’ve seen it since.
Take care.
Forum: Plugins
In reply to: [User Menus - Nav Menu Visibility] Notice Keeps Coming Back…@carmpocalypse – Sorry to hear that, is it a Freemius notice?
@jordanek – Sorry to hear that. Curious if you opened a support ticket, or if you had a specific issue that you couldn’t work out?