Daniel Iser
Forum Replies Created
-
@dwrippe As nothing in the changes from one version to another would suddenly change the url, nor do we use jQuery to cause that to load, I have to assume the change caused one of your other plugins to render content differently.
Also of note, that version of jQuery is not supported, not included with WP core either, so something on your site is causing that to load outside of our plugin, such as the theme for example.
Hopefully Kim was still able to help you track it down, just closing this here in the mean time.
- This reply was modified 1 year, 1 month ago by Daniel Iser.
@namrur – Sorry to hear that, but those files & lines are not related to our plugin.
Our plugin would be
/wp-content/plugins/content-control/, not/wp-content/plugins/content-restriction/@mrfent37 Sorry your having trouble. That said we have reviewed everything, both on your initial report and latest update. To be clear, we didn’t ignore it, BUT as you may have determined, it is clearly unrelated to our official code at all. No version has ever commented that out, going back many versions, & no other user has reported such an issue. That would brick every site using that version, and given there are several 100k sites using it already the forums would be slammed.
- https://plugins.trac.ww.wp.xz.cn/browser/popup-maker/tags/1.19.2/classes/Extension/License.php#L419
- https://plugins.trac.ww.wp.xz.cn/browser/popup-maker/tags/1.20.3/classes/Extension/License.php#L430
What this likely indicates is you are currently using non-legit sources/copies of our plugin or extensions, likely from a 3rd party “GPL” site that is serving you modified copies of the plugin.
As such this your installations would not be supported by us, but rather the company you got them from.
To be clear, that code would never be commented out as it shows licensing alerts, but a GPL pirated copy would remove those for sure.
This is further evidenced by the fact that when you go to update the plugin, it shows a generic icon, not our plugins icon.

If your not using modified copies of our plugins (NULLED or cloned versions), then another plugin on your site is interfering and serving you updates from a non-verified sources.
If you are using NULLED plugins, just know they can put in whatever they like, including backdoors to your site. This is clearly verifiable given you are getting modified stuff already.
Also just know we do not provide support for them in any capacity.
Google AI says:
“Nulled” refers to software that has been cracked or pirated, meaning the licensing restrictions have been removed. While there’s no official “Popup Maker nulled” version, finding and using such a file is illegal and comes with risks. It can expose you to security threats and legal consequences. The official version of Popup Maker is available on ww.wp.xz.cn and offers a free plan, as well as paid options for advanced features.
Here’s why using a nulled version is problematic:
- Security Risks:Nulled software often contains malware or other malicious code that can harm your website and user data.
- Legal Issues:Using pirated software violates copyright laws and can lead to legal penalties.
- Lack of Support and Updates:You won’t receive official support, updates, or bug fixes, leaving your website vulnerable.
- Potential for Website Failure:Malfunctioning or corrupted code in a nulled plugin can destabilize your website.
Even some GPL sites admit they modify and what they serve is unsafe
However, using nulled plugins comes with risks such as security vulnerabilities, lack of updates, and no official support.
[ “GPL club” link deleted, please do not share that here ]Feel free to follow up , but I’m closing this because its clearly not an install we would support typically.
I will add we are happy to provide code snippets to tie their solutions into our plugin open/close events, but that would require their assistance first likely.
@vadimm5 – Looked at the site just now, honestly this isn’t an issue we can solve on our end. If you want the overlay functionality it comes with disabling the scrollbar, or duplicate scroll bars as you saw.
The sidebar isn’t part of our plugin, and what it does when the scrollbar is removed is out of our control.
So you could either change your popup to disable the overlay, or see if the author of the theme/plugin that created that sidebar can help resolve it repositioning when the scrollbar gets hidden.
Hope that helps.
@psteinweber – We use Bricks ourselves, I’ve experimented and have dev branches to try and get this working.
Here is a guide on how we currently use it: https://wppopupmaker.com/tutorial/how-to-create-a-free-popup-for-bricks-builder/
You can see here we have made attempts at making a direct editing experience possible
- https://github.com/PopupMaker/Popup-Maker/blob/61627b145eff2af28571c3bb9c4575ef79c9bda5/classes/Integration/Builder/Bricks.php#L12
- https://forum.bricksbuilder.io/t/builder-render-issues-with-custom-private-post-type/26553
Honestly I’m not sure the Bricks team wants this to work if I’m being honest.
@aledef Due to the way the recursion happens, my guess is they started either filtering all post types, or added a query to terms inside their filters that didn’t exist before.
Possible introductions of conflict:
- Filtering pre_get_posts: https://github.com/franmastromarino/wp-search-exclude/compare/v2.1.7…v2.1.8#diff-c9aa604d2b9379c7c892d6f6d8330c48c8ae80326f57b9bc3af92d8a3437549aR19
- Not returning the
$querywhen returning early: https://github.com/franmastromarino/wp-search-exclude/compare/v2.1.7…v2.1.8#diff-c9aa604d2b9379c7c892d6f6d8330c48c8ae80326f57b9bc3af92d8a3437549aR28 - Introduction of
get_termswithin an existing query filter: https://github.com/franmastromarino/wp-search-exclude/compare/v2.1.7…v2.1.8#diff-c9aa604d2b9379c7c892d6f6d8330c48c8ae80326f57b9bc3af92d8a3437549aR69-R84
We haven’t been able to track what is hogging the memory so far as I can tell, the changes in 2.5.0 were related to caching restriction checks against each post, and storing the list of post_ids we needed to reset if we had to overload the global $post.
So it should have only had 1 at a time unless there was some deeply nested checks, but given we disable checks entirely on block editor template types, I can’t imagine anything where there would be posts rendered within posts nested so deeply that it fills up gigabyte of memory.
Best bet honestly, clone site to staging, comment out each of our Frontend Restriction methods one by one until the issue resolves, then uncomment the others.
My guess classes/Controllers/Frontend/Restrictions/QueryPosts.php, filtering post arrays.
If that is the case we’d need to further then dig into exactly where in that entire section of code and everything it calls it breaks by further commenting out code or returning early checking for where the issue goes away again.
The error messages are simply too generic to be helpful and the replication of this reliably in a test environment up until now not great.
Happy to help, testing this on our end as well.
EDIT: Can confirm this was easy to replicate with this particular plugin, digging into it now.- This reply was modified 1 year, 2 months ago by Daniel Iser.
@bearstar thanks, got that on my radar now.
@stvwlf – Correct, instead of having to mark each page one by one, this plugin lets you set your restrictions globally choosing which content using rules like
Is a Post with Selected Tagin any combination you see fit.The you choose who can see the content
Logged In Usersin your case, and what should happen if they don’t have permission underProtectionsettings.Hope that helps.
@peter8nss – Found it, thanks for the continued reports and patience: https://github.com/code-atlantic/content-control/blob/fd5e94b2e5f0e658554d9714abd152a6df834b38/inc/functions/rule-callbacks.php#L863
Try changing
- this:
&& $post_type_object->publicly_queryable; - to this
&& ! $post_type_object->exclude_from_search;
Seems to resolve it for me.
@yesyeswordpress – Thanks for the feedback. We offer WooCommerce support in the is fully built into our Pro version. SureCart support is on our todo list.
As for the phrase I’d have to double check where its located, but first assumption for “Restricted to”, it means Restricted to the users that CAN see the content. So effectively reaffirming the other statement.
@bearstar – Pushing an update shortly that should reduce heavily the memory usage in these particular functions. No idea if it resolves yours specifically but was a safe & performant change just he same.
@emmaevolving – I have this working in our Pro version for
posts, need to polish it to work for all content types.Can have this pushed in an update farily quickly thanks for the idea.
Here is what I worked out
Content Was/Was Not Published Within X Days
Content Was/Was Not Published Before XX/XX/XXXX- This reply was modified 1 year, 2 months ago by Daniel Iser.